Strip mentions from forwarded messages #30884
Conversation
|
|
github-actions
bot
added
the
Z-Community-PR
As there is no EditorModel, attachMentions() currently does nothing
There was a problem hiding this comment.
This runs forwarded messages through attachMentions() — which just effectively sets m.mentions to empty, as there is no EditorModel for the forwarded message. This feels like the least-bad way to fix #30883 in alignment with the existing codebase, while leaving room for future improvements. Actually determining the m.mentions based on the message body would likely require some degree of structural changes.
| }; | ||
|
|
||
| const transformEvent = (event: MatrixEvent): { type: string; content: IContent } => { | ||
| const transformEvent = (event: MatrixEvent, userId: string): { type: string; content: IContent } => { |
There was a problem hiding this comment.
This function was just about squeaking by without doc as an internal function, although it still wasn't super clear in what way it's transforming it. Now it has another param, I think it really does need doc as I have absolutely no guesses as to what this function might do with the user ID it's been given.
| }; | ||
| } | ||
|
|
||
| // Force an empty m.mentions property as there is no EditorModel to parse pills from |
There was a problem hiding this comment.
Since we are explicitly forwarding an event here, I'd make this comment closer to what you have in the PR description, ie. talking about the fact we're stripping mentions from a forwarded message and why.
3 participants
Fixes #30883
Checklist
public/exportedsymbols have accurate TSDoc documentation.